Partial fix for #31
Entries with the protocol-oriented-programming tag
Added to work around https://bugs.swift.org/browse/SR-14103
Overall this is pretty minor but when dealing with a lot of
SingleElementSections that are infrequently updated is does start to slow down.
I thought a faster approach would be to use generics on
replace(element:) to only check for
nil when the value is
Optional, but generics don't allow for this kind of overload.
Also added some basic tests. The performance tests show a ~9% performance increase.
This PR is being used to diff between the OpenNet fork.
Hopefully other PRs will be merged before this (e.g. https://github.com/composed-swift/Composed/pull/21), which should lead to this PR having no changes and purely to ensure some of the history is not lost.
We've discussed returning
-1 not being great previously, but now we have the
2.0 branch we can make this change :)
@bill201207 found that
UINib(nibName:bundle:) is a big part of the poor performance when our app launches.
Ultimately batching updates will help with a lot of things like this, but really that'll just be masking some of the performance issues so it's useful to find issues like this now.
This adds the
ComposedUI packages, which will close #16.
The base for this is
2.0-beta, which we can use for testing new changes, which can also break API.
If you go to the repo settings you can (temporarily) set the default branch to
2.0-beta and we can add a note to the README stating this is the beta release and the stable release is available in the
Once merged and these changes are made the READMEs for
ComposedUI repos can be updated to point to this repo and their repos archived.
This is a new type of section that is similar to
ComposedSectionProvider, but rather than flattening each of the children in to a single
SectionProvider it flattens them in to a single
ComposedUI side of this has been updated to support multiple cells per section, with a convenience for
FlatSection that delegates the calls to each of the flattened sections.
This is a breaking change since the protocol requirements have changed. I have set the base of the PR to
merge-all-libraries since that's also a breaking change and this PR relies on those changes.
edit: We've moved to our own fork to allow for more rapid development. The latest changes are in https://github.com/opennetltd/Composed/tree/feature/FlatSection, which will eventually be merged back in to this repo once some of the other PRs/issues have been resolved.
In my open source frameworks I usually use the last major Xcode (currently 11.7), latest (currently 12.3) and latest beta (soon to be 12.4), but this project has only been setup for the latest version of Xcode.
If we feel it's good to run the tests across multiple Xcode versions I have created https://github.com/JosephDuffy/update-xcode-version-action, which we can use to keep the versions in-sync with the versions available as part of GitHub actions.
For now I've removed all use a explicit Xcode versions.
Regression introduce in 1.1.1.
Would occur when a segmented provider was the last child of a composed provider and the selected segment changed.
This could have also been fixed in
SegmentedSectionProvider but changing the
_currentIndex after the delegate has been notified (which is closer to what
ComposedSectionProvider does) but we have nothing in the API contract stating this must be done, so really it's an issue with the caching in
These properties are accessed quite frequently and can be cached with a little extra processing.
This is another finding from screens that have a large number of composed sections.
This and https://github.com/composed-swift/ComposedUI/pull/15 seem to be the main areas of performance issues, although that doesn't mean that once these are working and merged we won't uncover more 😅
Thanks to @bill201207 for their contributions to this change.
The idea of this is that without breaking the API the collection view will batch updates.
Inserting a large number of sections is the main area of performance loss we are currently encountering, because the sections are inserted individually and not batched. This change alone has reduce the initial load time of one our screens (which has 100-150 sections added at once) from 30-45 seconds down to less than a second (at least it is not noticeable).
I had created https://github.com/composed-swift/Composed/pull/17 to try and address this, which has the advantage that it would apply to other view types (e.g.
UITableView), but I believe does not offer the same performance improvements and it is restricted to a single
This is a draft to collect feedback; as you can see there are some TODOs but I think there's enough implemented to provide an overview of the changes that would be required to implement this.
This does not currently work; there are situations that cause the collection
NSInternalInconsistencyException', reason: 'Invalid update error. I have some failing tests that demonstrate what the result should be.
When adding a lot of sections (we have a screen which inserts 100~175 on initial load) the performance is quite poor.
Along with the
improve-composed-section-provider-performance branch (which I want to fully validate before making a PR) performing these changes in batch helps a lot.
As mentioned in https://github.com/composed-swift/ComposedUI/issues/13 and https://github.com/composed-swift/ComposedUI/issues/8 there are some scenarios where the collection view’s data is out-of-sync with the data in composed.
As mentioned in https://github.com/composed-swift/ComposedUI/issues/13 calling
layoutIfNeeded can trigger the data to be in sync again. In this I have added it to
mappingWillBeginUpdating(_:) which appears to solve the problem.
It might be needed in
reloadData is called) and/or
mappingDidInvalidate(_:) (for the same reason) but I’m still investigating.
I have validated this fix against https://github.com/composed-swift/ComposedUI/issues/8 and it fixes the crash.
https://github.com/composed-swift/ComposedUI/issues/13 still needs to be investigated and may require
layoutIfNeeded to be called in
mappingDidInvalidate. Marking as a draft until this is checked.