Entries with the open-source tag

Pull request Add quotes around fix missing symbols URL on getsentry/sentry

Opened 8th July, 2019

When copy/pasting this command in fish (untested in other shells) the shell will try to expand the URL due to the ? in the URL (No matches for wildcard 'https://sentry.io/api/0/projects/[...]/processingissues/fix?_=[...]'. See `help expand`.)

This was raised in support request 22916. Colleen was kind enough to point me to this line of code.

I am not totally familiar with JSX syntax so I hope that simply adding quotes works and does not need any escaping.

Pull request Add support for GitHub bot users on danger/swift

Opened 26th June, 2019

I have added Dependabot to one of my projects, and Danger Swift is failing because the PR was created by a bot user: https://github.com/JosephDuffy/Partial/pull/14, https://travis-ci.com/JosephDuffy/Partial/jobs/211151759.

I used the GitHub API to request the data for the above PR and then used the value of theuser key to create a test for decoding this type of user.

It looks like the documentation should be updated to reflect the new UserType case. I have run make docs, but it only updates half of the docs, eventually failing in ./Scripts/update_docs.rb with:

The operation couldn’t be completed. (SourceKittenFramework.Request.Error error 2.)
/System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/json/common.rb:156:in `initialize': A JSON text must at least contain two octets! (JSON::ParserError)
	from /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/json/common.rb:156:in `new'
	from /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/lib/ruby/2.3.0/json/common.rb:156:in `parse'
	from ./Scripts/update_docs.rb:27:in `<main>'

It would appear that SourceKitten is throwing an error, but I am unable to figure out how to debug/fix this! :(

Partial v0.2.0

Released 26th June, 2019

Release Notes

  • Remove non-throwing value(for:) functions
  • Remove subscripts that return Partials
  • Rename set(value:for:) to setValue(_:for:)
  • Add lots of tests

Pull request Update Carthage to create a single archive on facebook/facebook-ios-sdk

Opened 14th May, 2019

Carthage expects a single .zip file containing all frameworks for all platforms. The current method means that only the FBSDKCoreKit framework will be downloaded (when not using --no-use-binaries), this should allow them to all be downloaded automatically by Carthage.

Thanks for proposing a pull request.

To help us review the request, please complete the following:

Pull request Support embedding data sources in a carousel on thread/Composed

Opened 13th May, 2019

Classing as a draft since there are likely a few issues and this hasn't really been used "in the wild" yet.

But anyway I think this is the basic required.

The general idea is that the EmbeddedDataSource implements a few more of the delegate methods around sizing, and has a custom sizing strategy. Overall the API is pretty much the same (it needs to be told the sizing strategy for the embedded data source but I think that's it).

One odd thing is that the data source you pass in to the embedding one will contain a sizing strategy, but it will be largely (maybe entirely?) ignored, but it still needs to provide UI because it's going to be providing the cells themselves.

YetiiLiib 0.2.2

Released 22nd December, 2015

Release Notes

Updated App Store URL generation

Fixed error when loading app store from generated URLs Moved logic for generating App Store URL to the AppMetaData struct Improved documentation around App Store URLs