Pull request ComposedSectionProvider fixes on composed-swift/Composed
These were quite hard to track down since the errors that would occur would often be visual and not a crash, although in some scenarios it did seem to trigger a crash.
I think this highlights the need for a much larger test suite.
Sidebar
It also made me question the insert(_:at:)
functions because it's not really clear what the index
is. Should it insert it at the index in the context of the sections and providers (as it does now), or just sections?
For example, with:
- Section A
- Section Provider
- Section B
- Section C
- Section D
- Section E
If I insert a section at index 3 should it look like:
- Section A
- Section Provider
- Section B
- Section C
- New Section
- Section D
- Section E
or
- Section A
- Section Provider
- Section B
- Section C
- Section D
- New Section
- Section E