Pull request Misc improvements on opennetltd/Composed
- Tags:
- open-source
This is an improvement but it's not quite a fix yet.
I think the issue is in the transforming of the index paths. We probably need to work with a mixture of the current and the transformed index paths in ChangesReducer.removeElements(at:)
but I can't figure out the right mix and need to step away for a bit to clear my head of this, hopefully coming back with "fresh eyes."
I'm hoping this is a clearer API compared to using SelectionHandler.shouldSelect(at:)
or SelectionHandler.didSelect(at:)
.
The primary change here is to enable strict concurrency checks via ~~-Xfrontend -strict-concurrency=complete
~~ the StrictConcurrency
experimental featyre. The main knock-on effect of this is that @MainActor
has been added to most protocols and types.
I also:
name
parameter on the dependency declaration has been deprecatedUICollectionView
s
UITableView
. The PR in the main repo now includes these extensionsrequired
initialisers on ArraySection
have been removed
assertMacroExpansion
fails, it incorrectly displayed the expected source as the expanded source.assertMacroExpansion
test functionXCTFail
While using this function I was confused by the error message. I think it should include the actual expansion, not what's expected?
I also renamed the variable to try and make it a little clearer and (assuming this is correct) prevent a mistake like this again. This was done in 3c46da3712dec11e5d485c96b6b7d9d40b7c8f25 so can be easily reverted.
Initial support for caching values in-memory
Fix crash when multiple updates create publishers simultaneously
I've been working on a fix for a bug in Overamped, which causes the popover UI shown when tapping on an image in Google Images to be blank, if the link goes to an AMP page. This was a silly bug that never should've happened; knowing that Google can change their page structure at any time I should've been more cautious with my checks.
As a temporary quick fix I removed all custom handling of Google results, tested my changes in the simulator, and uploaded a new build to TestFlight.
After installing the TestFlight update on my phone I checked a search result that I knew recreated the problem, but it was still happening! I have other extensions installed so I disabled some, refreshed, and the bug was fixed!
I thought it would be very strange for the same – very specific – bug to appear in multiple extensions, so I did a little digging.
Fix deadlock when adding a new subscriber inside the closure of an update listener