Previously the global path was being passed, but the configuration is created in the local scope of the data source
Initial release with
PartialBuilder, and Swift 5.1 beta support
As discussed in #1179 this PR updates the
release Fastlane lane to upload a zip archive containing prebuild versions of Kingfisher to GitHub
Currently only the mapping is done, still all the UI etc. to be done
Carthage expects a single .zip file containing all frameworks for all platforms. The current method means that only the FBSDKCoreKit framework will be downloaded (when not using
--no-use-binaries), this should allow them to all be downloaded automatically by Carthage.
Thanks for proposing a pull request.
To help us review the request, please complete the following:
- sign contributor license agreement
- describe the change (for example, what happens before the change, and after the change)
Classing as a draft since there are likely a few issues and this hasn't really been used "in the wild" yet.
But anyway I think this is the basic required.
The general idea is that the
EmbeddedDataSource implements a few more of the delegate methods around sizing, and has a custom sizing strategy. Overall the API is pretty much the same (it needs to be told the sizing strategy for the embedded data source but I think that's it).
One odd thing is that the data source you pass in to the embedding one will contain a sizing strategy, but it will be largely (maybe entirely?) ignored, but it still needs to provide UI because it's going to be providing the cells themselves.
I'm not 100% about the lack of support for optionals here.
On one hand I think it could be up to the caller to not create this with a
nil element, but on the other hand I can see it might be useful to return
numberOfElements(in:) when the value is